On Fri, 2010-09-03 at 15:15 +0200, jprov...@redhat.com wrote: > Hi, > this is first shot in image/template revamp. Most important is patch 1/3 > (models). Patches 2 and 3 are usable if you want to see it alive. > I'm sending it now in order to you could check a direction of these changes > (especially models) and stop me if something is wrong. > > Jan >
Jan, I spent some time looking at these today, and while there are clearly bits remaining to be implemented (including, but not limited to, tests and validations), I think the overall direction is good. Some random thoughts I had while reviewing: * Template summary - we will need to show this in the ui. I know we have it in the xml field, but it is cumbersome to pull it out for display (either in speed or in code complexity)? * We probably need somewhere to store registration state of image (at least for ec2, it has to be registered, and aggregator needs to know if this has been done or not). Perhaps this could just be the :provider_image_key field you have on image-providers since there will be no key if the image has not been registered (though not positive if a key is created on upload to ec2 even before registration). * I saw somewhere an assumption that the warehouse would return the uri where the template or image has been stored, but as I understand it, aggregator will actually be the one that determines this - warehouse just stores things at whatever uri w/in the system that you tell it to. That said, exactly where everything will be stored, or how we decide that programatically is tbd. * Images likely need somewhere to store (and eventually a method to call) the status of replication of the image to the chosen provider. In other words, if I build an image for ec2 and push it to the warehouse, when the warehouse is instructed to upload it to s3 (either directly or via some policy), the engine needs to be able to know whether that upload is complete or not. This is another one that details of such a call are tbd, but the concept of knowing replication status will be there in any case. Scott may have other thoughts/details I missed, but I think you are on the right track, and this is worth pursuing. Until/unless we hear otherwise, I would say any other major missing chunks can be added in subsequent patches, as getting this in will enable us to revamp the image and template listing actions in other parts of the app. -j _______________________________________________ deltacloud-devel mailing list deltacloud-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/deltacloud-devel
