@#1: based on your answer (in jira) i pushed it. @#2: with [1] i removed the mentioned parts because they aren't used for other methods internally - the tested constellation is still the same. if we agree on it, i'll push it as well.
regards, gerhard [1] http://s.apache.org/wU 2012/1/18 Jason Porter <[email protected]> > On Tue, Jan 17, 2012 at 16:14, Gerhard Petracek > <[email protected]>wrote: > > > hi @ all, > > > > today i reviewed it. my findings: > > > > #1: > > imo we shouldn't have public impl classes in the api module >if< we can > > avoid it. i made a small refactoring to reduce the visibility of those > > classes and i attached a patch which shows the suggestion at [1]. > > > > Okay, if we state in the docs to use the builder to create all the > annotated types you'd need in the life cycle events I'm fine with that. > > > > #2: > > i had a short talk with pete about AnnotationRedefiner. it looks like > that > > it was introduced to provide an alternative syntax to the other builder > > methods esp. for complex cases. > > imo we should re-visit it (esp. if there are really that many cases which > > really benefit from it - compared to using the other builder methods). > > > > Also fine taking this out in favor of using the builder methods. > > > > regards, > > gerhard > > > > [1] https://issues.apache.org/jira/browse/DELTASPIKE-45 > > > > > > > > 2012/1/7 Jason Porter <[email protected]> > > > > > I have the classes all checked into my branch [1]. Please review. I > know > > > many of them need Javadoc, so you can forget that part. Mainly the > > > AnnotatedTypeBuilder needed many classes that were in Solder Impl. As I > > > believe AnnotatedTypeBuilder is pretty helpful for everyone doing CDI > > > Extension development I put them all in api, so we'll have some *Impl > > > classes in api. If everyone is okay with that, great. Otherwise we may > > need > > > to find a new place to put them as we can't put them in impl and keep > > > AnnotatedTypeBuilder in api. > > > > > > [1] > > https://github.com/LightGuard/incubator-deltaspike/tree/DELTASPIKE-45 > > > > > > -- > > > Jason Porter > > > http://lightguard-jp.blogspot.com > > > http://twitter.com/lightguardjp > > > > > > Software Engineer > > > Open Source Advocate > > > Author of Seam Catch - Next Generation Java Exception Handling > > > > > > PGP key id: 926CCFF5 > > > PGP key available at: keyserver.net, pgp.mit.edu > > > > > > > > > -- > Jason Porter > http://lightguard-jp.blogspot.com > http://twitter.com/lightguardjp > > Software Engineer > Open Source Advocate > Author of Seam Catch - Next Generation Java Exception Handling > > PGP key id: 926CCFF5 > PGP key available at: keyserver.net, pgp.mit.edu >
