afaik seam-catch provides features we haven't imported so far which could
help here.
providing a >customized< PersistenceStrategy (-> impl. dependency) just for
overriding this method isn't that nice and should only be the last resort.

i know that it isn't an easy topic, but we should try it at least (instead
of just removing a todo which is in place for a good reason).

regards,
gerhard



2012/6/19 <[email protected]>

> Updated Branches:
>  refs/heads/master 89bc56fb9 -> 8d40092e2
>
>
> remove catch TODO. This method is for preparation only.
>
> The prepareException(e) method just repackages a given Exception and
> might extract additional information. This is useful if e.g. a JPA
> provider wraps a Database Exception in his own or for adding info
> about failed tests in a ConstraintViolationException
> which by default has a meaningless text.
>
> We don't do catch integration in this spot because we don't throw
> anything.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/commit/8d40092e
> Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/tree/8d40092e
> Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/diff/8d40092e
>
> Branch: refs/heads/master
> Commit: 8d40092e264ede6c4cbf07ea1a8af185faacdc38
> Parents: 89bc56f
> Author: Mark Struberg <[email protected]>
> Authored: Tue Jun 19 15:05:01 2012 +0200
> Committer: Mark Struberg <[email protected]>
> Committed: Tue Jun 19 15:05:01 2012 +0200
>
> ----------------------------------------------------------------------
>  .../ResourceLocalPersistenceStrategy.java          |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-deltaspike/blob/8d40092e/deltaspike/modules/jpa/impl/src/main/java/org/apache/deltaspike/jpa/impl/transaction/ResourceLocalPersistenceStrategy.java
> ----------------------------------------------------------------------
> diff --git
> a/deltaspike/modules/jpa/impl/src/main/java/org/apache/deltaspike/jpa/impl/transaction/ResourceLocalPersistenceStrategy.java
> b/deltaspike/modules/jpa/impl/src/main/java/org/apache/deltaspike/jpa/impl/transaction/ResourceLocalPersistenceStrategy.java
> index 0311ae6..38e1fbb 100644
> ---
> a/deltaspike/modules/jpa/impl/src/main/java/org/apache/deltaspike/jpa/impl/transaction/ResourceLocalPersistenceStrategy.java
> +++
> b/deltaspike/modules/jpa/impl/src/main/java/org/apache/deltaspike/jpa/impl/transaction/ResourceLocalPersistenceStrategy.java
> @@ -259,7 +259,6 @@ public class ResourceLocalPersistenceStrategy
> implements PersistenceStrategy
>      */
>     protected Exception prepareException(Exception e)
>     {
> -        //TODO integrate with the exception-handler provided by ds-core
>         return e;
>     }
>
>
>

Reply via email to