First we mention in the comment that we will try to use the "WebApp ClassLoader first" which is also not really true if we use DeltaSpike with cdictrl Next, we mention "fallback: Try ClassLoader for ClassUtils (i.e. the > myfaces.jar lib)
On Wed, Sep 12, 2012 at 12:53 PM, Romain Manni-Bucau <[email protected]>wrote: > what's the issue? > > *Romain Manni-Bucau* > *Twitter: @rmannibucau* > *Blog: http://rmannibucau.wordpress.com* > > > > > 2012/9/12 Charles Moulliard <[email protected]> > > > Nevertheless, we should perhaps adapt the code as ClassUtils could also > be > > used using JavaSE .... > > > > public static Class loadClassForName(String name) throws > > ClassNotFoundException > > { > > try > > { > > // Try WebApp ClassLoader first > > return Class.forName(name, false, // do not initialize for > > faster startup > > getClassLoader(null)); > > } > > catch (ClassNotFoundException ignore) > > { > > // fallback: Try ClassLoader for ClassUtils (i.e. the > > myfaces.jar lib) > > return Class.forName(name, false, // do not initialize for > > faster startup > > ClassUtils.class.getClassLoader()); > > } > > } > > > > > > > > On Wed, Sep 12, 2012 at 11:59 AM, Mark Struberg <[email protected]> > wrote: > > > > > Sure, go on! > > > > > > LieGrue, > > > strub > > > > > > > > > > > > > > > ----- Original Message ----- > > > > From: Charles Moulliard <[email protected]> > > > > To: [email protected] > > > > Cc: > > > > Sent: Wednesday, September 12, 2012 10:38 AM > > > > Subject: Can we remove this comment ? > > > > > > > > Hi, > > > > > > > > In the ClassUtils of deltaspike core module, there is a mention of a > > > > myfaces.jar file, can we remove it ? > > > > > > > > /** > > > > * Loads class for the given name > > > > * @param name name of the class > > > > * @return loaded class > > > > * @throws ClassNotFoundException if the class can't be loadedx@ > > > > */ > > > > public static Class loadClassForName(String name) throws > > > > ClassNotFoundException > > > > { > > > > try > > > > { > > > > // Try WebApp ClassLoader first > > > > return Class.forName(name, false, // do not initialize for > > faster > > > > startup > > > > getClassLoader(null)); > > > > } > > > > catch (ClassNotFoundException ignore) > > > > { > > > > // fallback: Try ClassLoader for ClassUtils (i.e. the > > myfaces.jar > > > > lib) > > > > return Class.forName(name, false, // do not initialize for > > faster > > > > startup > > > > ClassUtils.class.getClassLoader()); > > > > } > > > > } > > > > > > > > Regards, > > > > > > > > -- > > > > Charles Moulliard > > > > Apache Committer / Sr. Pr. Consultant at FuseSource.com > > > > Twitter : @cmoulliard > > > > Blog : http://cmoulliard.blogspot.com > > > > > > > > > > > > > > > -- > > Charles Moulliard > > Apache Committer / Sr. Pr. Consultant at FuseSource.com > > Twitter : @cmoulliard > > Blog : http://cmoulliard.blogspot.com > > > -- Charles Moulliard Apache Committer / Sr. Pr. Consultant at FuseSource.com Twitter : @cmoulliard Blog : http://cmoulliard.blogspot.com
