Module: deluge
Branch: pieces-progress-bar
Commit: 71f411e458f11067c12cd17016055c37c5e3c25e

Author: Pedro Algarvio <[email protected]>
Date:   Thu May 19 00:29:30 2011 +0100

Some comment explanation.

---

 deluge/ui/client.py |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/deluge/ui/client.py b/deluge/ui/client.py
index d356b22..b2de0b1 100644
--- a/deluge/ui/client.py
+++ b/deluge/ui/client.py
@@ -182,6 +182,13 @@ class DelugeRPCProtocol(Protocol):
                 exception_cls = getattr(error, request[2])
                 exception = exception_cls(*request[3], **request[4])
 
+                # Ideally we would chain the deferreds instead of instance
+                # checking just to log them. But, that would mean that any
+                # errback on the fist deferred should returns it's failure
+                # so it could pass back to the 2nd deferred on the chain. But,
+                # that does not always happen.
+                # So, just do some instance checking and just log rpc error at
+                # diferent levels.
                 r = self.__rpc_requests[request_id]
                 msg = "RPCError Message Received!"
                 msg += "\n" + "-" * 80

-- 
You received this message because you are subscribed to the Google Groups 
"deluge-commit" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/deluge-commit?hl=en.

Reply via email to