On Tue, Mar 16, 2010 at 10:08 AM, Damien Churchill <[email protected]> wrote: > On 16 March 2010 17:03, Shane Fagan <[email protected]> wrote: >> On Tue, 2010-03-16 at 16:03 +0000, Damien Churchill wrote: >>> On 10 March 2010 21:21, Andrew Resch <[email protected]> wrote: >>> > On Wed, Mar 10, 2010 at 2:26 AM, Damien Churchill <[email protected]> >>> > wrote: >>> >> >>> >> >>> >> On 10 March 2010 02:16, Andrew Resch <[email protected]> wrote: >>> >>> >>> >>> On Tue, 2010-03-09 at 22:56 +0000, Shane Fagan wrote: >>> >>> > Hi all, >>> >>> > Ubuntu lucid will have a new way to display things and is going to be >>> >>> > used from now on. The docs are here >>> >>> > https://wiki.ubuntu.com/DesktopExperienceTeam/ApplicationIndicators >>> >>> > its >>> >>> > a standard coming for Ubuntu and KDE desktops(although no news on the >>> >>> > gnome upstream yet). It has a fallback to the notification area for >>> >>> > those who dont support the spec. Could you guys implement this in >>> >>> > Deluge? I can offer some help if needed. >>> >>> > >>> >>> > Regards >>> >>> > Shane Fagan >>> >>> > >>> >>> >>> >>> Hey Shane, >>> >>> >>> >>> Yes, this could probably be done. >>> >>> >>> >>> I'm looking at the Python example at the ubuntu wiki. How do you >>> >>> connect an "activate" and "popup-menu" event to the Indicator object? >>> >>> Does the Indicator object sub-class GtkStatusIcon? >>> >>> >>> >>> I don't really see any connect method defined here: >>> >>> >>> >>> http://bazaar.launchpad.net/~indicator-applet-developers/indicator-application/trunk/annotate/head%3A/bindings/python/appindicator.defs >>> >>> >>> >>> Of course there could be a different way to do things, but in the >>> >>> interest of being able to reuse code, it'd be desirable if this new >>> >>> object provided GtkStatusIcon's functionality. >>> >>> >>> >> >>> >> It looks to me like you are supposed to set a Menu to display and then >>> >> the >>> >> indicator will handle showing it for you, as for doing something when it >>> >> is >>> >> clicked, I can't see anyway to do this. >>> >> >>> > >>> > Yea, that was my concern. It would be mean different behaviour on >>> > Ubuntu systems which could cause some user frustration. >>> > >>> >>> It's also an extra thing for us to have to take into consideration >>> which isn't ideal. >> It isnt Canonical/Ubuntu pushing a spec on everyone kde developed the >> spec and it was adopted by Canonical so we can have a cross desktop spec >> thats better than the notification area mess. It hasnt been officially >> been adopted by Gnome though. The fallback in the code means that you >> arent going to cause frustration to anyone else, you are only providing >> extra goodness for Ubuntu and any other desktop that takes up the spec. >> > > Yes but as far as we can see there is no "activate" signal available > to connect to, which we currently make use of as well as the > "popup-menu" signal. > > Looking at the docs you provided we only have the ability to provide > the indicator with a menu, we can't handle the signals ourselves > directly. > > This is why we are saying we'd have to have 2 code paths in order to > adopt this currently. >
Yea, I don't have any problem adding this in, we just need to make sure it provides the same level of functionality that is afforded by the GtkStatusIcon we currently use. Shane, you mentioned earlier that you are willing to help out with the implementation, so I assume you have some experiencing doing this already. Perhaps you could take a peek at our code: http://git.deluge-torrent.org/deluge/plain/deluge/ui/gtkui/systemtray.py and perhaps you'll see what we mean by connecting to some signals on the GtkStatusIcon object. -- You received this message because you are subscribed to the Google Groups "Deluge Dev" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/deluge-dev?hl=en.
