#1972: Useless ui.UI class
-----------------------+----------------------------------------------------
 Reporter:  jumentous  |       Owner:            
     Type:  patch      |      Status:  new       
 Priority:  minor      |   Milestone:  1.4.0     
Component:  core       |     Version:  git master
 Keywords:             |  
-----------------------+----------------------------------------------------
 Whilst it would appear that the ui.py:UI class used to be intended for
 something it is only used in 2 places:

 1. from start_ui where it is called to choose which UI to launch. However
 at no point here does it use self so in essence this could/should just be
 a function.

 2. as a base class for deluge/ui/web/web.py:Web, however the __init__ of
 this class does not chain to the parent class or do anything similar.

 I can only imagine that this cross over came from old, removed code and is
 no longer needed.

 This code can simply be merged back into start_ui, if for no other reason
 that it's less confusing for people reading the code and distinguishing
 the difference between the _UI and UI classes.

-- 
Ticket URL: <http://dev.deluge-torrent.org/ticket/1972>
Deluge <http://deluge-torrent.org/>
Deluge project

-- 
You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/deluge-dev?hl=en.

Reply via email to