#1858: [console] Add command 'manage' to show/set per-torrent options
---------------------+------------------------------------------------------
 Reporter:  eirikba  |       Owner:  Cas           
     Type:  patch    |      Status:  assigned      
 Priority:  minor    |   Milestone:  1.3.x         
Component:  console  |     Version:  git 1.3-stable
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by nogare):

 Eirikba: I talked to Cas on IRC regarding adding the prompt, and he said
 that if we are using '*' to specify "all loaded torrents", then a prompt
 of confirmation isn't needed.

 I've just started testing your code, and have some ideas on how to improve
 `--help`

 {{{

 >>> manage --help
 Usage: manage <torrent-id> [<torrent-id> ...] [<key1> [<key2> ...]]
        manage <torrent-id> [<torrent-id> ...] --set <key> <value>

        torrent-id can be "*" to signify all loaded torrents'
        max_connections, max_download_speed, max_upload_slots,
 max_upload_speed can be set to -1 to signify unlimited

 Available keys:
        auto_managed: Makes torrent obey deluge's queue settings.(see FAQ
 for details)
        max_connections:  Maximum number of connections to use for this
 torrent
        max_download_speed:  Maximum total download speed to allow this
 torrent to use (KiB/s)
        max_upload_slots:  Maximum number of connections to use for
 uploading for this torrent
        max_upload_speed:  Maximum total upload speed to allow this torrent
 to use (KiB/s)
        move_completed:  Whether to move the downloaded data when
 downloading is complete.
        move_completed_path:  Where to move completed data to (if
 "move_completed" is True)
        remove_at_ratio:  Whether to remove torrent when share ratio
 reaches "stop_ratio".
        stop_at_ratio:  Whether to stop seeding when share ratio reaches
 "stop_ratio".
        stop_ratio:  The ratio at which to stop seeding (if "stop_at_ratio"
 is True)

 }}}
 '''the above is suggested new output, you can run it(above) and current
 help through http://www.quickdiff.com/ to see changes'''

 Also a quick comment on your code:

 {{{
 11:28      nogare| There is no need to have options which cannot be set
 commented out e.g the following comments
  11:28      nogare| #'compact_allocation': bool, # Unclear what setting
 this would do
  11:29      nogare| #'add_paused': ???, # Not returned by get_status,
 unclear what setting it would do
  11:29      nogare| etc..
 }}}

 I'll post when i'm done testing

-- 
Ticket URL: <https://dev.deluge-torrent.org/ticket/1858#comment:17>
Deluge <http://deluge-torrent.org/>
Deluge project

-- 
You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/deluge-dev?hl=en.

Reply via email to