#2065: [Console] Crash upon forgetting closing quote
---------------------+------------------------------------------------------
Reporter: nogare | Owner:
Type: defect | Status: new
Priority: trivial | Milestone: Future
Component: console | Version: git 1.3-stable
Keywords: |
---------------------+------------------------------------------------------
{{{
>>> rm --remove_data foo"
rm --remove_data T[ERROR ] 15:31:31 screen:307 No closing quotation
Traceback (most recent call last):
File
"/usr/local/lib/python2.6/dist-packages/deluge-1.3.4_dev-
py2.6.egg/deluge/ui/console/screen.py", line 305, in doRead self._doRead()
File "/usr/local/lib/python2.6/dist-packages/deluge-1.3.4_dev-
py2.6.egg/deluge/ui/console/screen.py", line 318, in _doRead
self.command_parser(self.input.encode(self.encoding))
File "/usr/local/lib/python2.6/dist-packages/deluge-1.3.4_dev-
py2.6.egg/deluge/ui/console/main.py", line 299, in do_command
args = self._commands[cmd].split(line)
File
"/usr/local/lib/python2.6/dist-packages/deluge-1.3.4_dev-
py2.6.egg/deluge/ui/console/main.py", line 115, in split
return shlex.split(text)
File
"/usr/lib/python2.6/shlex.py", line 279, in split
return list(lex)
File
"/usr/lib/python2.6/shlex.py", line 269, in next token = self.get_token()
File
"/usr/lib/python2.6/shlex.py", line 96, in get_token
raw = self.read_token()
File "/usr/lib/python2.6/shlex.py", line 172, in read_token
raise ValueError, "No closing quotation"
ValueError: No closing quotation
}}}
If you type a command say `rm --remove_data "foo bar` and hit enter
console dies. Instead the user should be informed that they forgot to add
a closing quotation.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2065>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/deluge-dev?hl=en.
