#2250: Speedup removing multiple torrents from core
-------------------+--------------------------------------------------------
Reporter: bro | Owner:
Type: patch | Status: new
Priority: minor | Milestone: performance
Component: core | Version: master (git branch)
Keywords: |
-------------------+--------------------------------------------------------
Comment(by Cas):
A few notes:
* `remove_all()` is a misleading function name, maybe
on_remove_torrents() and also change remove_torrent() for
on_remove_torrent()?
* This import should be at top: `from twisted.internet import reactor,
task`
* the docstring in core.remove_torrents needs updated
* torrentmanager.remove() method should be renamed to remove_torrents,
it's not descriptive enough (easily confused with list.remove()). Also the
method requires an updated docstring.
* The type check in torrentmanager.remove() should be changed so it
raises an exception if it's not a list however maybe just remove it as all
remove methods should go through core for clients and we can verify that
other calls in core use the torrentmanager method correctly.
* We discussed in IRC whether the clients need to know (or care) why a
torrent could not be removed, I can't remember the conclusion but do need
to verify whether current clients can handle this change e.g. webui.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2250#comment:5>
Deluge <http://deluge-torrent.org/>
Deluge project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/deluge-dev?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
