#2738: Illegal argument to libtorrent set_max_connections
-------------------------+---------------------------
Reporter: bro | Owner: bro
Type: bug | Status: assigned
Priority: minor | Milestone: 2.0
Component: libtorrent | Version: develop (git)
Resolution: | Keywords:
-------------------------+---------------------------
Comment (by bro):
I opened a [https://github.com/arvidn/libtorrent/issues/41 libtorrent
issue github] but we didn't conclude on anything (it seems). Also I
believe we may disagree about how asserts should be used.
I guess the simplest solution to fix this in deluge is to ensure that the
values passed to libtorrent calls are valid. In the case of
set_max_connections, 0 and 1 are not valid input values (according to
docs) and gives an assert error when compiled in debug mode. When not in
debug mode, 0 is actually treated as -1 and means unlimited. I don't know
what happens when passing in 1, but presumably it should be avoided since
docs says it must be minimum 2.
--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2738#comment:4>
Deluge <http://deluge-torrent.org/>
Deluge Project
--
You received this message because you are subscribed to the Google Groups
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.
