#2861: libtorrent-rasterbar 1.1.x+ GeoIP support
  Reporter:  XRevan86  |      Owner:
      Type:  patch     |     Status:  new
  Priority:  minor     |  Milestone:  2.0
 Component:  Core      |    Version:  develop (git)
Resolution:            |   Keywords:

Comment (by Cas):

 Looking good but needs a few tweaks.

 You can replace the `isalpha` loop with list comprehension:

 `country = "".join([ char if char.isalpha() else " " for char in country

 Need to use a more descriptive var name than `gi`.

 Also shouldn't have a bare `try..except` with pass.

 It would be better if `self.geoip_instance` defaults to `False` rather
 than `None`.

 If you have a github account you could provide this patch as a PR.

Ticket URL: <http://dev.deluge-torrent.org/ticket/2861#comment:2>
Deluge <http://deluge-torrent.org/>
Deluge Project

You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to deluge-dev+unsubscr...@googlegroups.com.
To post to this group, send email to deluge-dev@googlegroups.com.
Visit this group at https://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to