#2848: Incorrect share ratio in torrent status
-------------------------+-------------------------------------------------
  Reporter:  ph33onix    |      Owner:
      Type:  bug         |     Status:  new
  Priority:  minor       |  Milestone:  2.0
 Component:  Core        |    Version:  1.3.6
Resolution:              |   Keywords:  share ratio total_done
                         |  all_time_download
-------------------------+-------------------------------------------------

Comment (by Cas):

 So it used to be `all_time_download` until:

 [8e7d4f2cd47532]
 > Change share ratio calculation to use the total done instead of the all
 time downloaded value. This change will make the share ratio calculation
 not use data downloaded in failed hash checks.

 [[br]]

 I am thinking that `total_wanted_done` is going to be better for torrents
 with unwanted files.

 ----

 Reference tickets: #646, #2072 and lt docs:

 {{{
 total_done
     the total number of bytes of the file(s) that we have. All this does
 not necessarily has to be downloaded during this session (that's
 total_payload_download).

 total_wanted_done
     the number of bytes we have downloaded, only counting the pieces that
 we actually want to download. i.e. excluding any pieces that we have but
 have priority 0 (i.e. not wanted).

 total_wanted
     The total number of bytes we want to download. This may be smaller
 than the total torrent size in case any pieces are prioritized to 0, i.e.
 not wanted

 all_time_upload all_time_download
     are accumulated upload and download payload byte counters. They are
 saved in and restored from resume data to keep totals across sessions.
 }}}

--
Ticket URL: <http://dev.deluge-torrent.org/ticket/2848#comment:3>
Deluge <http://deluge-torrent.org/>
Deluge Project

-- 
You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to