#1316: Implement file/folder renaming in Web UI
------------------------------+--------------------------------------
  Reporter:  powtrix          |      Owner:  damoxc
      Type:  feature-request  |     Status:  assigned
  Priority:  major            |  Milestone:  2.x
 Component:  Web UI           |    Version:  1.3.0_dev
Resolution:                   |   Keywords:  rename file folder webui
------------------------------+--------------------------------------

Comment (by alexandernst):

 I finally managed to get my eyes through the code! :)

 My very first impression: deluge is extremely hard to get working on mac!
 Luckily, I took notes of the entire process and I'll share it (maybe in a
 README.mac?).

 I spotted where the magic for this FR happens (kudos, code is very clean
 and predictable), but it's not working as expected. After renaming a file,
 the UI won't refresh.

 This is caused because of `name`, the last argument of
 `_on_torrentfilerenamed_event`, which should be a `str`, but it's some
 sort of object (which doesn't happen to behave as a `str` and the code
 crashes as soon as it gets to `name.split()`).

 Anyways, I managed to "fix" that by placing `name = name.im_self.name` on
 the top of that function. That seems to return the correct name and set it
 to `name`, but then the UI freezes, and I believe it's because it's busy-
 waiting for some other event.

 Can you confirm that renaming is currently working in GTK UI?

--
Ticket URL: <http://dev.deluge-torrent.org/ticket/1316#comment:12>
Deluge <http://deluge-torrent.org/>
Deluge Project

-- 
You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/deluge-dev.
For more options, visit https://groups.google.com/d/optout.

Reply via email to