#3201: Create Windows package (Py3-GTK3)
------------------------------+---------------------
  Reporter:  Cas              |      Owner:
      Type:  feature-request  |     Status:  new
  Priority:  major            |  Milestone:  2.1.x
 Component:  Packaging        |    Version:  develop
Resolution:                   |   Keywords:
------------------------------+---------------------

Comment (by Cas):

 Replying to [comment:12 Doadin]:
 > Also still getting an error with the simulate() workaround in connection
 manager
 >
 >
 > {{{
 >   File "C:\Python\Python37\lib\site-
 packages\deluge-2.0b2.dev302-py3.7.egg\deluge\ui\gtk3\connectionmanager.py",
 line 144, in show
 >     reactor.simulate()
 >   File "C:\Python\Python37\lib\site-
 packages\twisted\internet\_glibbase.py", line 385, in simulate
 >     timeout = min(self.timeout(), 0.01)
 > TypeError: '<' not supported between instances of 'float' and 'NoneType'
 > }}}
 >

 Create a new upstream ticket: https://twistedmatrix.com/trac/newticket

 It is an issue with migrating Twisted to Python 3. Python 2 was happy to
 compare different types but Python 3 is stricter and raises a `TypeError`.

 Your suggested fix needs tweaked:
 {{{#!diff
 -        timeout = min(self.timeout(), 0.01)
 -        if timeout is None:
 -            timeout = 0.01
 +        timeout = self.timeout()
 +        if timeout is None:
 +            timeout = 0.01
 +        timeout = min(timeout, 0.01)
 }}}

 In Deluge probably just catch the error and pass or remove it, if it does
 nothing anymore. The associated comment is not so helpful:

 `# XXX: We need to call a simulate() here, but this could be a bug in
 twisted`

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3201#comment:13>
Deluge <https://deluge-torrent.org/>
Deluge Project

-- 
You received this message because you are subscribed to the Google Groups 
"Deluge Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/deluge-dev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/deluge-dev/057.cb28e157c57213006939d185665ab490%40deluge-torrent.org.
For more options, visit https://groups.google.com/d/optout.

Reply via email to