On Fri, 2013-05-10 at 17:38 +0200, Éloi Rivard wrote: > Well, you were right, it is because of the <scheme> tag in > Default.commands. > > Now on the 'remove_commands_c' I removed commands.c and it seem to > work. > > I can see no warnings, saving and loading custom commands work fine. > What else should I test ? I have built and tested this with creating new user commands and loading otherwise hidden ones; all well :) So I think merge should be ok Richard
> > > > > 2013/5/10 Éloi Rivard <[email protected]> > Yep I saw that. Well let's do it little by little. > > I updated 'refactoring' and removed the commands.c removing > commit. > > This is simple variables renaming and code splitting. > > Pleas tell me if it is ok to merge. > > > > 2013/5/10 Richard Shann <[email protected]> > On Fri, 2013-05-10 at 13:12 +0200, Éloi Rivard wrote: > > It seems to be because of commands.c deletion. I > check that. > > The current code executes anything in commands.c and > then goes on to go > through Default.commands picking up anything which > commands.c has not > already loaded. So the current code should execute ok > with a dummy > commands.c > Richard > > > > > > > > > 2013/5/10 Richard Shann <[email protected]> > > On Fri, 2013-05-10 at 11:20 +0200, Éloi > Rivard wrote: > > > I reworked the 'refactoring' branch, > (based on intl) and > > checked the > > > user actions creation. It should be good > this time. Please > > check > > > > > > I checked out the refactoring branch and > built > > from ./autogen.sh on to a > > new directory, on statup I get > > > > .... > > ** (denemo:5038): WARNING **: > > A script error for > > > file/script > /home/denemo-user/local/share/denemo/actions/denemo.scm; the > > throw arguments are > > (#f Unbound variable: ~S (d-SetBreve) #f) > > > > > > It looks like only built-in commands are > loaded :( > > there are no others in the menu system. > > > > Richard > > > > > > > > > > > > > > 2013/5/9 Éloi Rivard <[email protected]> > > > There is something on the 'intl' > branch. I need some > > test. > > > > > > I had to suppress spaces from > actions/menus file > > paths to make > > > it work. > > > > > > I updated Defaults.commands to > follow the right > > menupaths. > > > > > > You will probably need to > run ./autogen.sh once to > > compile > > > successfully. > > > > > > > > > > > > Now you can update translations > with : > > > cd po > > > > > > make update-po > > > > > > > > > I made some tests with a clean > user (no > > ~/.denemo.xxx > > > directory). I created a command, > saved it, closed > > the program, > > > launch it again, it seems to work. > > > > > > Let me know if it is mergeable. > > > > > > > > > > > > 2013/5/9 Richard Shann > <[email protected]> > > > On Thu, 2013-05-09 at > 15:19 +0200, Éloi > > Rivard wrote: > > > > Indeed people who have > their own command > > file may > > > want to keep them > > > > working. > > > > > > > > There is many solutions: > > > > > > > > - Keep support for old > style files in the > > code, but > > > that's not my > > > > favorite > > > > > > > > - Tell people to update > their files, and > > possibly > > > give theme a script > > > > to do that > > > > > > > > > This last is fine - those > who have created > > command > > > files will not have > > > many and will be easily > technically savvy > > enough to > > > update them. (I just > > > realized that the > spell-checker does not > > recognize > > > savvy as a good word, > > > but I am sure any one with > savoir-faire will > > > understand :) > > > > > > Richard > > > > > > > > > > > > > > > > > > > > > -- > > > Éloi Rivard - [email protected] > > > > > > « On perd plus à être indécis qu'à > se tromper. » > > > > > > > > > > > > > > > -- > > > Éloi Rivard - [email protected] > > > > > > « On perd plus à être indécis qu'à se > tromper. » > > > > > > > > > > > > > > > > > -- > > Éloi Rivard - [email protected] > > > > « On perd plus à être indécis qu'à se tromper. » > > > > > > > > > -- > Éloi Rivard - [email protected] > > « On perd plus à être indécis qu'à se tromper. » > > > > > -- > Éloi Rivard - [email protected] > > « On perd plus à être indécis qu'à se tromper. » > _______________________________________________ Denemo-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/denemo-devel
