In fact I can see a newly introduced (?) bug which may have its origin in this code change: the thumbnail invocation of Denemo is failing. On quitting Denemo it is spawning Denemo again to get the thumbnail and gives the following error:
Denemo 1_1_1 Loaded keymap /home/rshann/.denemo-1.1.1/actions/Default.commands (denemo:24542): Gtk-CRITICAL **: gtk_menu_shell_insert: assertion `GTK_IS_MENU_SHELL (menu_shell)' failed (denemo:24542): Gtk-CRITICAL **: gtk_action_group_get_action: assertion `GTK_IS_ACTION_GROUP (action_group)' failed Arranger Profile (denemo:24542): Gtk-CRITICAL **: gtk_window_set_title: assertion `GTK_IS_WINDOW (window)' failed (denemo:24542): Gtk-CRITICAL **: gtk_notebook_get_nth_page: assertion `GTK_IS_NOTEBOOK (notebook)' failed (denemo:24542): Gtk-CRITICAL **: gtk_notebook_set_tab_label_text: assertion `GTK_IS_NOTEBOOK (notebook)' failed (denemo:24542): Gtk-CRITICAL **: gtk_notebook_set_menu_label_text: assertion `GTK_IS_NOTEBOOK (notebook)' failed (denemo:24542): Gtk-CRITICAL **: gtk_label_set_text: assertion `GTK_IS_LABEL (label)' failed Actually, as I write this, I recall some problem before with thumbnailing since you started to work on non-interactive testing - this looks different however from what I recall before. Richard On Tue, 2013-11-26 at 09:52 +0000, Richard Shann wrote: > On Tue, 2013-11-26 at 09:23 +0100, Éloi Rivard wrote: > > It was part of my effort to factorize and reduce code in callbacks.h. > > Oh - I thought it was part of trying to get non-interactive invocation > working without gtk. In this case the crash is more serious - it was > crashing because during file loading the scheme callback route was not > used and so displayhelper() was not called, by moving the call to > displayhelper() down into the addmeasures() routine you caused it to be > called during file loading (I would guess that Denemo.gui is not set up > at that stage). So it is more serious because you moved displayhelper() > down into other low-level routines, and the same crash may be waiting > for us when a file is loaded which require those. > This, of course, brings us back to the main thing we need, tests. (That > is why I hoped and assumed that the crash was due to you trying to get > testing working, rather than general improvements to the code). It will > be much easier to improve the code generally once a good set of tests > are present. In particular, the excellent improvement of removing the > passing of the global value Denemo.gui around could only safely be done > when tests are present that will fail if the parameter "gui" refers not > to the global Denemo.gui but to a DenemoGUI* which is being created and > populated - as during file loading, and possibly other things such as > switching tabs. > > Can you list the places where you have moved the displayhelper() call, > and with a view to looking over where they can occur in the call tree? > > Richard > > > > > _______________________________________________ > Denemo-devel mailing list > [email protected] > https://lists.gnu.org/mailman/listinfo/denemo-devel _______________________________________________ Denemo-devel mailing list [email protected] https://lists.gnu.org/mailman/listinfo/denemo-devel
