Building 2.1 for Fedora 25 fails due to a missing semicolon in
denemo-2.1/pixmaps/denemo.desktop. The line

Categories=GNOME;Audio;AudioVideo;Music;Education

should have a final semicolon. During install, rpmbuild executes the command

  desktop-file-install --vendor=""\
        --dir=%{buildroot}/%{_datadir}/applications\
        --add-category=X-Notation\
        %{buildroot}/%{_datadir}/applications/denemo.desktop

This appends "X-Notation;" at the end of the Categories line, resulting in
an invalid Category "EducationX-Notation".

Yes, one can argue that desktop-file-install should do a better job
especially since
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#basic-format
reads:

  Some keys can have multiple values. [...] The multiple values
  should be separated by a semicolon and the value of the key may be
  optionally terminated by a semicolon.

-- Johan
*** pixmaps/denemo.desktop~	2017-03-20 18:06:27.213315139 +0100
--- pixmaps/denemo.desktop	2017-04-27 13:16:47.693672338 +0200
***************
*** 4,10 ****
  StartupNotify=true
  Terminal=false
  Type=Application
! Categories=GNOME;Audio;AudioVideo;Music;Education
  MimeType=audio/midi;application/denemo;
  
  Name=GNU Denemo
--- 4,10 ----
  StartupNotify=true
  Terminal=false
  Type=Application
! Categories=GNOME;Audio;AudioVideo;Music;Education;
  MimeType=audio/midi;application/denemo;
  
  Name=GNU Denemo
_______________________________________________
Denemo-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/denemo-devel

Reply via email to