Should patches also update functional tests?

[Satheesh Bandaram]

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1   I would like to seek suggestions or comments regarding submitting patches with appropriate test changes. Since Derby now has functional tests, should we suggest or even require patches to be submitted along with a test case added? This will only apply if a test case is available and doesn't require undue amount of time and resources to test the patch. Obvious advantages are:    1. We can be sure we are indeed addressing the problem. Unless committers write a test case based on the code changed, we may not know for sure we did fix the problem correctly.    2. Can prevent future regressions in the code, where the same defect is reintroduced because of another patch or enhancement.    3. Strengthens Derby funtional test suites and test coverage. This may introduce additional burden on patch submissions, hence, we could make this voluntary to start with. How do other Apache projects handle this? Satheesh -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org   iD8DBQFBo5qHENVNIY6DZ7ERAiXKAJ4u2LqRt6DQRmyD9tnVrUKcnU+9zACfcqRc t9KHweaziJ934nzRpqTLZvQ= =+2mR -----END PGP SIGNATURE-----