-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Shreyas Kaushik wrote:
> Hi all, > > The patch for this after taking care of handling the map conditions the > following way, is attached: > > null Map --> throw a SQLException > empty Map --> no-op > non-empty Map --> throw notImplemented. > > thanks > Shreyas Just a couple of minor fixups are needed to the patch. 1) The SQLState (NULL_MAP_PASSED) needs a more generic name since it's intended for any invalid parameter. Eg. INVALID_API_PARAMETER 2) getObject(String colName, java.util.Map map) should be implemented by just calling getObject(findColumnName(columnName, map)). This is consistent with the other getXXX(colName) methods and means a single set of checks for the map variable. Can you modify your changes and re-submit the patch. Thanks, Dan. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFBpK/8Iv0S4qsbfuQRAqhuAKDa1QGL7RCcrmOvLdCy3Evq8IK+8QCdHLX6 4B6e2XuQbf8mi1urB+KPBy4= =/MJ0 -----END PGP SIGNATURE-----
