Re: [PATCH] Change all Identifier Limitations to 128

[Lance J. Andersen]

If the changes being made differ from the DB2 limits, and it does make sense to change this now that Derby is part of apache, I would pull the constants out of DB2Limit.java as this seems confusing from the outside looking in. I would actually advise against that, or at least a more controlled approach than just changing DB2 to Derby. The fact that they are marked as DB2 limits indicates why they were put in place, this may be useful information in the future. It identifies a limit that most likely is soft, rather than inherent in the Derby architecture. So I would say for the 128 identifier limit, it should be moved out of DB2Limit, as 128 is inherent to Derby, the system tables are all set at 128 characters for identifiers. Or maybe it is inherent to the SQL standard and thus the limit is described as a SQLStandard limit? But the other limits, I would leave as DB2Limit constants until someone changes them. You make a good point.  There are constants that do not begin with DB2_ (decimal  type limits for example) already, are these DB2 limits or Derby? Are there other known changes that can be made as part of this patch to revert to the previous values prior to the DB2 limits being implemented?