-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Shreyas Kaushik wrote:
> Here is the latest version of the patch with the aprropriate messages. > > thanks > Shreyas Great, can I commit this with a couple of minor changes? 1) In EmbeddedDataSource rename the local variable you added from 'toClose' to 'conn'. This is because in most cases this Connection object is not going to be closed, so the name is misleading. 2) Discard all the changes for EmbeddedXADataSource. Now that getConnection() correctly does not return null, it is no longer necessary to check for its return being null. Once those changes are removed from this file, all the other changes are cosmetic. Thanks, Dan. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.5 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFB78LyIv0S4qsbfuQRAl+lAJ0ao6ngh4Zk869Twc4C9yIPSV/u0wCeLalw 2fBzJFAsv7Ebl0n0rQKyDX4= =R0RB -----END PGP SIGNATURE-----
