On Fri, 21 Jan 2005 09:22:33 -0800, Daniel John Debrunner <[EMAIL PROTECTED]> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Kathey Marsden wrote: > > I agree, there were two reasons I removed files from patches that had > cosmetic cleanups: > [snip]
<delurk> A couple of notes about how other Apache projects address these issues might be helpful: * Cosmetic changes that bring existing code into conformance with the project's agreed upon coding standards (or clean up typos etc.) are generally welcomed, but should be *separated* from changes that have functional differences. * The "conformance" statement above, of course, requires that the project developers have an agreed upon set of standards :-). Apache doesn't impose any such guidelines ... it should be up to the committers on a particular project. There is also a more informal convention for functional-change patches, that you conform to the "local" style of the surrounding code, even if it does not currently conform to the community standards. </delurk> Craig McClanahan
