> Jack Klebanoff wrote: > > I have modified my patch so that the optimizer and BackingStoreHashtable > use the same decision about when a hash table will spill to disk. > > [snip] > > Since I made changes to the optimizer and hash join code generator I > hope that a Derby language expert can review at least that part of my > updated patch. >
I'm far from a "Derby language expert", but I did take the time to review the patch and it looks good to me. I successfully applied the patch to my local codeline, then ran the two tests that were included, and both passed. So not only do the changes/additions to the code look good, but the actual patch itself seems to be in good shape, too.
+1, Army
