Hello.
Thank for all who advise and help me !
Now I'm reading code of derby here and there , and found this program is very attractive.
I want to find next material for hacking :D
Best regards.
PS. I sended mail of ICLA last Thu. If no problem happened, It will arrive.
/*
Tomohito Nakayama
[EMAIL PROTECTED]
[EMAIL PROTECTED] Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html*/
----- Original Message ----- From: "Satheesh Bandaram" <[EMAIL PROTECTED]>
To: "Derby Development" <[email protected]>
Sent: Saturday, April 02, 2005 9:19 AM
Subject: Re: [Patch] Re: About improvement of DERBY-134
Submitted this patch. Thanks for patiently addressing all concerns. Final patch looks really good. Hope you will continue working on enhancing Derby. If you would like some ideas on what to tackle next, I can help... :-)
I think this improvement has been asked by several others in the community.
Satheesh
Sending
java\engine\org\apache\derby\impl\sql\compile\IntersectOrExceptNode.java
Sending
java\engine\org\apache\derby\impl\sql\compile\OrderByColumn.java
Sending java\engine\org\apache\derby\impl\sql\compile\TableName.java
Sending java\engine\org\apache\derby\impl\sql\compile\sqlgrammar.jj
Sending
java\testing\org\apache\derbyTesting\functionTests\master\orderby.out
Sending
java\testing\org\apache\derbyTesting\functionTests\tests\lang\orderby.sql
Transmitting file data ......
Committed revision 159746.
TomohitoNakayama wrote:
Hello.
Thanks. I see. I re-sended patch via JIRA.
I will send ICLA in days. Because it is a bit substantial , I need time ...
Best regards.
/*
Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED]
Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/ ----- Original Message ----- From: "Satheesh Bandaram" <[EMAIL PROTECTED]> To: "Derby Development" <[email protected]> Sent: Wednesday, March 30, 2005 3:43 AM Subject: Re: [Patch] Re: About improvement of DERBY-134
I will work on committing this patch. Since you are working on an improvement, would you mind submitting this patch through Jira? Use AttachFile option and you also need to select "Grant ASF license to include in ASF works" option. (URL: http://issues.apache.org/jira/secure/AttachFile!default.jspa?id=29790) This would help committers in accepting the patch.
Also, you might want to consider signing ICLA with Apache. (http://www.apache.org/licenses/icla.txt) This will help process your contributions faster. This is also a requirement to becoming a committer at a future time.
Satheesh
TomohitoNakayama wrote:
Waiting 1 day and no error was found. Can I ask committers to commit this patch ?
Or I should commit it by myself ?
Best regards.
/*
Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED]
Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/ ----- Original Message ----- From: "Jack Klebanoff" <[EMAIL PROTECTED]> To: "Derby Development" <[email protected]> Sent: Tuesday, March 29, 2005 4:31 AM Subject: Re: [Patch] Re: About improvement of DERBY-134
TomohitoNakayama wrote:
Hello.
I have added some test to orderby.sql (and correspond result to orderby.out) , which was suggested by Jack Klebanoff.
And I have executed derbylang test and coulud not found error exept for lang/floattypes.sql. I think this error is not caused by my patch.
derbylang_report.txt is attached to this mail.
Please check this patch from a point of other person's view.
best regards.
/*
Tomohito Nakayama [EMAIL PROTECTED] [EMAIL PROTECTED]
Naka http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
The latest patch looks good to me. I looked at the changes, applied the patch to recently updated Derby source, and successfully ran the derbylang test suite. (I did not even see the failure in lang/floattypes.sql that Tomohito saw. It was probably fixed in Derby updates I picked up today).
Jack Klebanoff
-- No virus found in this incoming message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
-- No virus found in this incoming message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.4 - Release Date: 2005/03/27
-- No virus found in this incoming message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.6 - Release Date: 2005/03/30
-- No virus found in this outgoing message. Checked by AVG Anti-Virus. Version: 7.0.308 / Virus Database: 266.8.6 - Release Date: 2005/03/30
