David
Mike Matrigali wrote:
I wasn't going to commit, I am not saying it shouldn't be committed - I
haven't had the time to look at it. Was just trying to help out understanding the state of current derby code - just wanted to make sure 2 space indentation wasn't checked it. Usually andrew looks at test commit stuff.
I now realize that I was wrong below. I do have tabstop set to 4 - and that is what is probably needed to make sense of most derby files. I now remember it was an argument I lost, a long time ago. If you have the choice my opinion it is best to set your editor to not generate tabs, and just do the 4 space indentation.
David Van Couvering wrote:
I opened the files in vi and set tabstop to 4 and things do look a lot better. I will adjust NetBeans to this formatting. Do you want tabs for indentation, or spaces?
I can't tell, but it sounds like you won't be committing this patch? I need to know so I can know whether to apply my logical changes to the files with the old formatting or the new formatting...
Thanks,
David
Mike Matrigali wrote:
Unfortunately from the beginning there was no imposed standard on the original cloudscape code. Predominantly most of the code is 4 space indentation, with 8 space tabs. Unfortunately there are some files that have been screwed up by IDE's. I like braces on a new line, but would say there is a large percentage of code with the other convention. Worst are files with both, changing code to be consistent in one file seems reasonable to me.
I just took a look at RunSuite.java and the indentation did not look that off to me (line 91-93 looks off, but a quick look did not find any other problems). (I use vim and others use emacs so we could provide settings if necessary).
The test suite code is one of the worst offenders and had been scheduled for a complete rewrite, but just never got the work allocated. It seemed better to contribute the tests in their existing state since they worked, rather than wait to fix them up.
David Van Couvering wrote:
Hi. I am working on supporting tests with multiple databases, and have been working with org.apache.derbyTesing.harness.RunSuite and RunList.
Both of these have some pretty "odd" formatting which has actually made
it hard for me to read and understand the logic, so I ran "reformat" in
NetBeans to get everything lined up. I tried to follow the standard
formatting that I seem to be seeing in the Derby code, in particular
braces on a new line, two spaces (no tabs) for indentation. Scanning
the mailing list, I don't see any votes about a specific coding standard...
I'd like to submit this as a separate patch so you don't get a huge number of diffs when I submit the patch that makes logical changes.
