Ok, thanks, that makes sense.
David
Daniel John Debrunner wrote:
David Van Couvering wrote:
Hi, Mamta, I have actually been trying to review this patch, but this is my first patch review, and I am learning *a lot* about how to set up a clean "drop" of Derby at the revision level you are at, applying and reviewing a patch. I do hope in the future my response time will be better.
In general you should be able to apply the patch at the latest (most recent) level of the trunk and not care about the specific revision level the patch was created at.
If I was committing a patch and there were conflicts at the most recent level then most likely I would request the contributor to resolve the conflicts and re-submit the patch. Usually the contributor is the best person to resolve any conflicts.
Thus as a reviewer, the same approach may be the best, any conflicts push the patch back to the contributor and ask them to re-submit.
Dan.
