The TestDurabilityProperty test currently checks if the amount of time to do insert is within a certain upper bound but on really *slow* machines it seems like the encryption run for this test can take longer than the upper bound set and can lead to diffs.

This is tricky because if the upper bound is set really high it may not really be a good test to check if this mode is broken or not on a good disk.
I plan to enhance this test so maybe we do some smarter checking to avoid failures on slow machines....


But for now, here is a simple patch that does a quick fix to disable this test for the encryption run and adds a comment in the test to say it could also fail if it ran on a really slow machine.

svn stat
M java\testing\org\apache\derbyTesting\functionTests\tests\store\TestDurabilityProperty.java
M java\testing\org\apache\derbyTesting\functionTests\suites\storemore.runall
M java\testing\org\apache\derbyTesting\functionTests\suites\storemats.runall


-- ran storemore and encryption suite ok.

Can a committer please commit this patch.

Thanks,
Sunitha.
Index: 
java/testing/org/apache/derbyTesting/functionTests/tests/store/TestDurabilityProperty.java
===================================================================
--- 
java/testing/org/apache/derbyTesting/functionTests/tests/store/TestDurabilityProperty.java
  (revision 169888)
+++ 
java/testing/org/apache/derbyTesting/functionTests/tests/store/TestDurabilityProperty.java
  (working copy)
@@ -88,6 +88,7 @@
                                          // millisecond
             if (timeTaken > approxUpperBound) {
                 report("FAIL -- derby.system.durability=test mode seems to be 
broken.");
+                report("or it is possible that test ran on a really SLOW 
machine!")
                 report(" Time to insert rows in test exceeded the usual 
limit.");
             }
 
Index: 
java/testing/org/apache/derbyTesting/functionTests/suites/storemore.runall
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/suites/storemore.runall  
(revision 169888)
+++ java/testing/org/apache/derbyTesting/functionTests/suites/storemore.runall  
(working copy)
@@ -27,3 +27,4 @@
 store/Beetle6038.java
 store/holdCursorJDBC30.sql
 store/holdCursorExternalSortJDBC30.sql
+store/TestDurabilityProperty.java
Index: 
java/testing/org/apache/derbyTesting/functionTests/suites/storemats.runall
===================================================================
--- java/testing/org/apache/derbyTesting/functionTests/suites/storemats.runall  
(revision 169888)
+++ java/testing/org/apache/derbyTesting/functionTests/suites/storemats.runall  
(working copy)
@@ -4,4 +4,3 @@
 store/longColumn.sql
 store/madhare.sql
 store/streamingColumn.java
-store/TestDurabilityProperty.java

Reply via email to