Committed, revision 170060. andrew
On 5/3/05, Susan Cline <[EMAIL PROTECTED]> wrote: > > Based on Myrna's feedback that I should not have included the part of my > path prior > to the java directory in the patch, attached is a new patch. > > If this looks okay, I'd appreciate it if someone would commit it. > > Thanks, > > Susan > > Susan Cline <[EMAIL PROTECTED]> wrote: > Andrew committed the new derbyclient last week and updated the > snapshot jars, including the Eclipse plug-in. When I downloaded > the derby_core_plugin_10.1.0.165185.zip file I noticed that > the plugin itself now contains derbyclient.jar, but the plugin.xml does not > list it as one of the libraries of the plugin. > > Without the addition of derbyclient.jar in the plugin.xml, > the derbyclient.jar file can not be used by the plugin. > > This patch remediates this problem and allows derbyclient.jar > to be used by the Apache Derby Core 10.1 plug-in. > > Tests run: verified the built plugin.xml file is well formatted > and includes derbyclient.jar. Verified, using sysinfo, the jars > contained in the plugins/org.apache.derby.core_10.1.0 > directory > are 10.1.0.0 alpha jars. > > This is my first patch, and although trivial, if I've done anything > incorrect > please let me know. Also, if this patch is acceptable, could a committer > please commit? > > Thanks, > > Susan > > Output of svn stat: > M > java\build\org\apache\derbyBuild\eclipse\DerbyEclipsePlugin.java > > Patch attached. > > > Index: > java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java > =================================================================== > --- > java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java > (revision 165362) > +++ > java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java > (working copy) > @@ -86,6 +86,9 @@ > "\t\t <library name=\"derby.jar\"> \n" > + > "\t\t\t <export name=\"*\"/> \n" + > "\t\t </library> \n" + > + "\t\t <library > name=\"derbyclient.jar\"> \n" + > + "\t\t\t <export > name=\"*\"/> \n" + > + "\t\t </library> \n" + > "\t\t <library > name=\"derbytools.jar\"> \n"+ > "\t\t\t <export name=\"*\"/> \n"+ > "\t\t </library> \n"+ > > >
