Submitted this patch. Thanks for working on this and for picking up
related 'dblook' change as well.
Transmitting file data ...........
Committed revision 178053.
Satheesh
TomohitoNakayama wrote:
Hello.
Thank you for your observing !
I have upladed the patch to
JIRA.
Best regards.
/*
*/
-----
Original Message -----
Sent:
Saturday, May 21, 2005 2:09 AM
Subject:
Re: Patch for DERBY-167 again*3
This looks good to me(+1). If there are no further comments, I will
commit it.
Since this is new feature, there may be a need for another +1 vote.
Satheesh
TomohitoNakayama wrote:
Hello.
I have made new patch.
What was changed was:
1 Modify comment in ColumnDefinitionNode.
2 Remove assert which became surplus in ColumnDescriptor
3 Add comment to complicated conditional _expression_ in ResultSetNode
4 Remove needless modification in ColumnDefintionNode. I found it when
trying to comment it.
5 Modify how DefaultInfoImpl have attribute of DefaultValueAutoinc.
6 Add final to DefaultInfoImpl.BITS_MASK_IS_DEFAULTVALUE_AUTOINC
Please review it again.
Best regards.
/*
Tomohito Nakayama
[EMAIL PROTECTED]
[EMAIL PROTECTED]
Naka
http://www5.ocn.ne.jp/~tomohito/TopPage.html
*/
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.12 - Release Date: 2005/05/17
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.13 - Release Date: 2005/05/19
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.14 - Release Date: 2005/05/20
|
