Kathey Marsden <[EMAIL PROTECTED]> writes:

[snip]
Thank you for committing the patch :)

> I saw from an earlier email that you are investigating whether the
> second part of this bug is
> the same as Derby-19 that Dan fixed   with svn 178795.
>
> I don't know if it is,  but  I think it makes sense for you to mark this
> bug fixed since you fixed the nape in network server and then you can
> open another issue for the SQL Exception if this is indeed a different
> issue than DERBY-19.

OK. From the description of DERBY-19 it looked like it could be the
same. But when I looked at the diff for 178795 I could not really see
how it could fix DERBY-128.

Anyway I have tried to run NSinSameJVM.java with the extra '/' and it
still fails (with NPE) even with DERBY-19... 
DERBY-128 takes care of the NPE, but it is correct to return an SQL
Exception in this case, isn't it?

I have looked into extending NSinSameJVM.java to test creation of a
database without write permission, and I have a couple of questions:

1) By extending NSinSameJVM.java this will not be tested in embedded
   mode. Is that OK? 

2) The output when NSinSameJVM.java fails contains non-printing
 characters:

main-NSinSameJVM: Derby drivers loaded
Server is ready to accept connections on port 20000.
Connection number: 1.
main-NSinSameJVM: NetworkServer started
Connection number: 2.
FAIL: Unexpected exceptionDERBY SQL error: SQLCODE: -1, SQLSTATE: XJ041, 
SQLERRMC: /NSinSameJVMTestDBXJ041.CXBM0H:/NSinSameJVMTestDBXBM0H.DFailed 
to create database '/NSinSameJVMTestDB', see the next exception for 
details.Directory /NSinSameJVMTestDB cannot be created.(server 
log:/export/home/tmp/DERBY/NSinSameJVM.java_Linux_20050604T131217/DerbyNetClient/NSinSameJVM/derby.log)org.apache.derby.client.am.SqlException:
 DERBY SQL error: SQLCODE: -1, SQLSTATE: XJ041, SQLERRMC: 
/NSinSameJVMTestDBXJ041.CXBM0H:/NSinSameJVMTestDBXBM0H.DFailed to create 
database '/NSinSameJVMTestDB', see the next exception for details.Directory 
/NSinSameJVMTestDB cannot be created.(server 
log:/export/home/tmp/DERBY/NSinSameJVM.java_Linux_20050604T131217/DerbyNetClient/NSinSameJVM/derby.log)

(Note the ^T characters)

 Is that expected? And is it safe to put this in an updated master
   file? Will it be portable?

Thanks,

-- 
dt


Reply via email to