[ http://issues.apache.org/jira/browse/DERBY-285?page=all ]

Kathey Marsden updated DERBY-285:
---------------------------------

    Attachment: derby285.diff

Rattaching patch after synching up with Dyre's change for DERBY-128.

Fix for DERBY-285 Network Client should not print non-ascii token separators in 
message when it cannot connect to the server to retrieve the error message

This patch  changes network server to send the complete message in its own 
locale instead of just the message arguments and delimiters if the exception is 
severe enough to terminate the connection.     This will eliminate the special 
characters and provide a more readable message. 
I also cleaned up the code a bit in this area.  I removed the extra logging for 
the severe exceptions as these will already be logged as part of the normal 
Derby error logging.


> Network Client should not print non-ascii token separators in message when it 
> cannot connect to the server to retrieve the error message
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-285
>          URL: http://issues.apache.org/jira/browse/DERBY-285
>      Project: Derby
>         Type: Improvement
>   Components: Network Client
>     Versions: 10.1.0.0
>     Reporter: Kathey Marsden
>     Assignee: Kathey Marsden
>  Attachments: derby285.diff
>
> If Network Client cannot connect to the database to retrieve an error 
> message, it will print only the message tokens, the non-ascii token 
> separators, and derby log location.  It would be good if at least the message 
> could be formatted to present a better message to the user without the 
> non-ascii characters.
> To reproduce try a database shutdown.  Because the database is shutdown, the 
> client cannot retrieve the actual message from the server. It therefore just 
> prints the tokens.
> Start network server
> java org.apache.derby.drda.NetworkServerControl start
> $ java org.apache.derby.tools.ij
> ij version 10.1
> ij> connect 'jdbc:derby://localhost:1527/wombat;create=true';
> ij> connect 'jdbc:derby://localhost:1527/wombat;shutdown=true';
> ERROR 08006: DERBY SQL error: SQLCODE: -1, SQLSTATE: 08006, SQLERRMC: 
> wombat[]08006.D[]Database 'wombat' shutdown.[](server log:derby.log)
> ij>
> Note: The actual offending characters have been replaced in the output in 
> this bug by []. This is because they break Jira XML retrieval!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to