Re: [PATCH] Updatable Resultset JDBC api (update and delete for forward only updatable resultsets) support for Network Server

[Mamta Satoor]

Hi,

 

Can someone please commit this minor patch?

 

thanks,

Mamta

 

On 6/4/05, Mamta Satoor <[EMAIL PROTECTED]> wrote:

Hi Satheesh,

 

I have a very small patch to address your review comments on Updatable Resultset support for Network Server using Derby Net Client.

 

svn stat

M      java\client\org\apache\derby\client\am\ResultSet.java

 

Please commit it if there are no issues.

 

thanks,

Mamta

 

On 5/23/05, Satheesh Bandaram <[EMAIL PROTECTED] > wrote:

Some minor comments... Use them if they apply....

1. Not sure if resultSetMetaData_.sqlxRdbnam_[baseTableColumn] is ever set, so no need to check for that.
2. Use sqlxBasename_ instead of sqlxSchema_ when looking for a valid base table. While both may work, it may be more readable.

Satheesh