>>>>> "DVC(" == David Van Couvering (JIRA) <[email protected]> writes:
DVC(> [ http://issues.apache.org/jira/browse/DERBY-243?page=all ]
DVC(> David Van Couvering updated DERBY-243:
DVC(> --------------------------------------
DVC(> Attachment: DERBY-243.diff
DVC(> Updated patch for this issue. Here is a summary of what I changed.
A lot of what I did was remove code I had put in,
DVC(> so I think you'll see a much simpler patch.
Looks very good. I am running derbylang on it know and will let you
know about the results when it is finished.
A few minor comments:
- EmbedPooledConnection.toString(): You do not have to create an
Integer object to convert int to String. You can use the static
Integer.toString(int) function.
- There is some unecessary white space changes. Adding or
removing empty lines are OK, but the use of "svn blame" (or
praise) becomes less useful if lines that are unrelated to the
check-in are changed. Even worse, checkDataSource30.java only
contains white space changes. This gives the false impression
that this test is changed by your fix.
- The Javadoc for checkDataSource.checkToString(Connection) seems
to lack the word "sure".
- You have changed the checkDataSource.main test so it may throw
an Exception. What is the purpose of that. Will the test
harness handle the Exception?
--
�ystein
