[ 
http://issues.apache.org/jira/browse/DERBY-319?page=comments#action_12313084 ] 

David Van Couvering commented on DERBY-319:
-------------------------------------------

I took a look at this patch and it looks good, very clean and well-documented.  
Looks like you also covered
some types that were missing in the metadata test.

My only question was why some of the columns in the metadata test  alltypes 
table, some of the columns 
have lots of underscores in them.  I couldn't follow the logic for this.

It compiles fine.  I am running derbyall and will add a separate comment 
regarding that when it completes.

> Derby returns incorrect values for "LENGTH" column of 
> DatabaseMetaData.getProcedureColumns() result set.
> --------------------------------------------------------------------------------------------------------
>
>          Key: DERBY-319
>          URL: http://issues.apache.org/jira/browse/DERBY-319
>      Project: Derby
>         Type: Bug
>   Components: JDBC
>     Versions: 10.0.2.1, 10.0.2.0, 10.1.0.0, 10.0.2.2
>     Reporter: A B
>     Assignee: A B
>     Priority: Minor
>      Fix For: 10.1.0.0
>  Attachments: derby-319.patch, derby-319.stat
>
> Based on discussion from the following thread:
> http://article.gmane.org/gmane.comp.apache.db.derby.devel/2585
> The Derby implementation of DatabaseMetaData.getProcedureColumns() returns 
> incorrect values for the "LENGTH" column of the result, primarily because 
> there is no clear definition in the JDBC spec regarding what this method is 
> _supposed_ to return.  Discussion in the above-posted thread concluded that 
> the intent of the JDBC metadata is to "match the ODBC metadata", at least 
> regard to this particular issue.  So changes reflecting this conclusion 
> should be submitted to Derby.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to