Hi, Kathey.  Thanks for checking this in (phew! :) ).

I will double-check my javadoc, I thought it was consistent.

Regarding the integer with no prefix, I thought this would allow you to do queries against VTIs using the current connection as a filter, e.g. (in pseudocode)

  SELECT * FROM ErrorLogVTI vti where vti.SESSID = conn.toString()

I also thought that normally in your trace code you would do

  System.out.println("Connection " + conn);

David

Kathey Marsden wrote:

Kathey Marsden (JIRA) wrote:


[ http://issues.apache.org/jira/browse/DERBY-243?page=comments#action_12313126 ]
Kathey Marsden commented on DERBY-243:
--------------------------------------

Committed patch to print connection id in connection.toString





Hi David,

Thanks David for all your work on connection toString().  I think it is
great that we have our connection toString hooked up to the error logs
in this way.

 I committed this patch.  There was some indentation with spaces  in
checkDataSource that I changed to tabs to match the rest of the file. Could you please update your comment about the connection toString semantics to match what went in. I see we went to just an integer without a prefix. So my
conn.toString() for my first connection prints:

0

I don't know why that  integer by itself seems a little funny to me, I
think I liked Connection_0  or some such better  but  I guess it's  ok.

Kathey

Reply via email to