Daniel John Debrunner wrote:
I'd be interested to know why a field was added? Seems a lot of code
added when the test of returnType == null determines if instance
represents a function or a procedure.
Yes, this is true, and indeed that was one of the comments I made in an email
yesterday. Without realizing the impact of adding a field to a serializable
object, I did it for the simple (and perhaps too subjective) sake of
'readability'. It seemed to me like it was clearer to read:
if (aliasType == AliasInfo.ALIAS_TYPE_PROCEDURE_AS_CHAR) ...
than
if (returnType == null) ...
But then again, since I commented all of the IFs that do this, we could probably
just switch to "returnType == null" without losing much 'readability'.
I can patch it that way if people want, since as you said that's less code, and
since comments in the right places make it clear what's being checked either way...
Army
