Hi Mamta, Thanks for reviewing this! >>>>> "MS" == Mamta Satoor <[EMAIL PROTECTED]> wrote: MS> MS> Oh, just one minor thing. I think a comment in the code as to why we have MS> (getToken(4).kind == LEFT_PAREN && getToken(2).kind != COMMA)} ) might help MS> a future developer understand the code.
Yes, I definitely agree. I'll do that and post an updated patch. Dag MS> thanks, MS> Mamta MS> MS> MS> On 6/13/05, Mamta Satoor <[EMAIL PROTECTED]> wrote: MS> > MS> > Hi Dag, MS> > I looked at the patch and it looks good to me. MS> > thanks, MS> > Mamta MS> > MS> > On 6/10/05, Dag H. Wanvik <[EMAIL PROTECTED]> wrote: MS> > > MS> > > Hi, MS> > > MS> > > I just uploaded a patch for this issue. Can somebody review it please? MS> > > It's small. MS> > > MS> > > Dag MS> > > MS> > MS> > MS> <div>Oh, just one minor thing. I think a comment in the code as to why we have (getToken(4).kind == LEFT_PAREN && getToken(2).kind != COMMA)} ) might help a future developer understand the code.</div> MS> <div> </div> MS> <div>thanks,</div> MS> <div>Mamta<br><br><br> </div> MS> <div><span class="gmail_quote">On 6/13/05, <b class="gmail_sendername">Mamta Satoor</b> <<a href="mailto:[EMAIL PROTECTED]">[EMAIL PROTECTED]</a>> wrote:</span> MS> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid"> MS> <div>Hi Dag,</div> MS> <div> </div> MS> <div>I looked at the patch and it looks good to me.</div> MS> <div> </div> MS> <div>thanks,</div><span class="sg"> MS> <div>Mamta<br><br> </div></span> MS> <div><span class="e" id="q_10476e7df6231a47_2"> MS> <div><span class="gmail_quote">On 6/10/05, <b class="gmail_sendername">Dag H. Wanvik</b> <<a onclick="return top.js.OpenExtLink(window,event,this)" href="mailto:[EMAIL PROTECTED]" target="_blank">[EMAIL PROTECTED]</a> MS> > wrote:</span> MS> <blockquote class="gmail_quote" style="PADDING-LEFT: 1ex; MARGIN: 0px 0px 0px 0.8ex; BORDER-LEFT: #ccc 1px solid">Hi,<br><br>I just uploaded a patch for this issue. Can somebody review it please?<br>It's small.<br><br>Dag MS> <br></blockquote></div><br></span></div></blockquote></div><br> MS> -- Dag H. Wanvik Sun Microsystems, Web Services, Database Technology Group Haakon VII gt. 7b, N-7485 Trondheim, Norway Tel: x43496/+47 73842196, Fax: +47 73842101 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
