Hi Kathey,
I am glad the patch resolved Derby-346 as well.
As for your review comment, the reason I am using reflection is that the code to handle holdability for both jdk13 and jdk14+ would be in just one place, BrokeredConnection.java. An alternative could be to let BrokeredConnection30 use direct method calls and in
BrokeredConnection.java, check if the jdk version is less than jdk4, and if so, use reflection to handle holdability. Let me know if seems better to replace the reflection code to handle both jdk13 and jdk14+ by having direct call in BrokeredConnection30 and reflection in BrokeredConnection.
thanks,
Mamta
On 6/18/05, Kathey Marsden <[EMAIL PROTECTED]> wrote:
Mamta Satoor wrote:
>
> Kathey, may be you can try this fix with Network Server and see if it
> resolves any related issues you had there?
>
This patch has corrected the failure I have been seeing for DERBY-346!
> Can someone review this patch for me? If no issues, can a commiter go
> ahead and commit it?
>
>
On the patch, I have just a question. We are now using reflection even
for BrokeredConnection30 (jdk14+). What is the potential impact of
switching to reflection for jdk14 rather than calling the setHoldability
method directly as before?
Thanks so much for your help with the holdability issues.
Kathey
