Jeff Levitt (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-275?page=all ]
Jeff Levitt updated DERBY-275:
------------------------------
Attachment: derby275finaldraft.zip
Attached is the new patch.
1) The "CREATE TABLE" section with this new patch has the following:
"See rrefsqlj24513.html#rrefsqlj24513__sqlj64478."
I think that's supposed to be "See Column Default" (looks like maybe the name of
the link has been lost/invalidated?)
2) There should be some kind of header/separation between the CREATE TABLE
syntax and the subsequent examples (even something as simple "Examples:" would
be fine). That, and/or move the CREATE TABLE syntax up so that it's just under
the header (and would then be followed by the description, which seems more
clear to me).
3) In the "column-definition" section, I think the syntax should be changed to
distinguish a "normal" column default from a generated column default. I.e.
Simple-column-Name DataType
[ Column-level-constraint ]*
[ [ WITH ] DEFAULT {ConstantExpression | NULL }
| generated-column-spec ]
[ Column-level-constraint ]*
That way it's more clear what the "Column default" paragraph in the
"column-definition" section is referring to. And of course, if you do this,
then you'd want to remove the "[ WITH ] DEFAULT {ConstantExpression | NULL }"
from the syntax in the "generated-column-spec" section.
Also, this may not be related at all to this patch, but as of this morning when
I try to open the PDF version of the Reference manual on the Apache website, I'm
getting an error saying "The file is damaged and could not be repaired." This
worked fine yesterday...
Hopefully these are the last changes required to complete this patch. And
please note that this is all just according to my own personal opinion; I'm
hoping that if anyone out there disagrees with any of this feedback (including
you, Jeff :), s/he will speak up...
Army
