[ http://issues.apache.org/jira/browse/DERBY-384?page=comments#action_12314443 ]
Stan Bradbury commented on DERBY-384: ------------------------------------- Stan's Review of: %%% Tuning Guide: Internal language transformations >> ON PAGE: http://incubator.apache.org/derby/docs/tuning/ctuntransform35783.html Predicate transformations ** the link list at the bottom appears TWICE. Remove duplicate list. >> ON PAGE: http://incubator.apache.org/derby/docs/tuning/rtuntransform208.html ** Remove duplicate link list. >> ON PAGE: http://incubator.apache.org/derby/docs/tuning/ctuntransform11313.html View transformations ** a) remove the link: ' Materialization ' - it is not related ** b) Remove duplicate links list (should have two links). >> ON PAGE http://incubator.apache.org/derby/docs/tuning/ctuntransform13699.html Subquery processing and transformations ** Remove duplicate (the SHORTER) link list. 5 item list is correct. >>ON PAGE: http://incubator.apache.org/derby/docs/tuning/ctuntransform16033.html Sort avoidance ** Remove duplicate link list. >> ON PAGE: http://incubator.apache.org/derby/docs/tuning/ctuntransform16279.html DISTINCT elimination based on a uniqueness condition ** CHANGE BULLET POINT: Secondary table ** NEW TEXT: Secondary table(s) >> AND ** clarify these TWO comments by using this text (I added the terms in parenthesis - after the words 'only table' and 'Primary table'): -- all the columns in the index on the only table (tab1) appear -- in the way required for the Primary table (simple column references) SELECT DISTINCT c1, c2, c3, c4 -- all the columns in the index on the only table (tab1) appear -- in the way required for the Primary table (equality predicates) SELECT DISTINCT c3, c4 > Doc Review: Tuning Derby > ------------------------ > > Key: DERBY-384 > URL: http://issues.apache.org/jira/browse/DERBY-384 > Project: Derby > Type: Improvement > Components: Documentation > Environment: all > Reporter: Jeff Levitt > Priority: Minor > Fix For: 10.1.1.0 > > This issue tracks comments for the manual known as Tuning Derby. The deadline > for posting comments is Tuesday, June 28, noon Pacific time. > Some guidelines to follow when posting comments to this issue are: > - Try to make clear and concise comments about what you want changed whenever > possible. Provide concrete comments that say "Please change <original> to > <modified>" instead of generic comments like "This section needs to be > rewritten." > - If you're reviewing the HTML Files copy, include the URL for the page in > the review comment. Obtain the URL like this: > * highlight the topic in the left frame > * right click > * choose "Properties" > * copy and paste the address in the pop up box. > - If you're reviewing the PDF copy, in the review comment: > * Include the page number for the PDF, and indicate whether the number is > the PDF sheet number or the printed page number. > * Include the title of the section that the problem occurs in. If it's in > a subsection, try to include the hierarchy of titles. > - Please don't review the HTML Book copy -- it'll be time consuming to match > up that copy with the underlying DITA source. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
