Daniel John Debrunner wrote:
Daniel John Debrunner wrote:
Daniel John Debrunner wrote:
I had to re-run the tests because the patch messed up on one file, but
now StmtCloseFunTest fails for me with this patch.
*** Start: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:08:57 ***
2a3
Statement Test failed (10)
4a6
Prepared Statement Test failed
7a10
Callable Statement Test failed
Test Failed.
*** End: StmtCloseFunTest jdk1.4.2 derbyall:jdbc20 2005-06-28 22:09:05 ***
I'll look into it, but is anyone else seeing this failure?
This is because the setQueryTimeout used to throw a not implemented
exception, but now succeeds. But in this case the statement is closed so
according to the JDBC spec, all such methods should throw an exception.
Oyvind, do you want me to commit your current patch (I've made the
copyright date changes, and performed the svn adds and propsets) and
then you could fix this problem quickly?
I wouldn't want to check in anything that is known to cause tests to
fail, even temporarily.
The fix is very simple; adding a call to checkStatus() at the very top
of EmbedStatement.setQueryTimeout() fixes the problem. If you want me
to, I can submit a new patch, but I think the quickest approach would be
if you just inserted the 'checkStatus()' call in your own sandbox.
Sorry for not catching this one myself; there was a lot of complaining
about broken builds and derbyall not running cleanly at the time, and I
guess I was just a bit lazy... Won't *ever* happen again. ;o)
--
Øyvind Bakksjø
Sun Microsystems, Web Services, Database Technology Group
Haakon VII gt. 7b, N-7485 Trondheim, Norway
Tel: x43419 / +47 73842119, Fax: +47 73842101
