[ http://issues.apache.org/jira/browse/DERBY-406?page=all ]

Philip Wilder updated DERBY-406:
--------------------------------

    Attachment: Derby406_409_410.patch

Removed the changes proposed by Dan Debrunner for an alternate patch.

This patch makes the following changes
- Sets the username to start with the default value ("APP", Derby-406 Fix)
- Sets the server name to start with the default value ("localhost", Derby-410 
Fix)
- Adds a semi-colon in the connection class to avoid databasenames like
myDBcreate=true resulting from no dividing semi-colon (Deby-409 Fix).
- Add javadoced methods in the derbynet/dataSourcePermissions_net.java file to 
test this new functionality
- Altered the output file for derbynet/dataSourcePermissions_net.java to 
accomodate for new tests.

Running the suite derbynetclientmats caused no problems. Running derbyall cause 
a single problem of the form:
 org.apache.derby.iapi.services.context.ShutdownException:
 agentThread[DRDAConnThread_5,5,derby.daemons]

Further investigation revealed that this was an intermittant problem for both 
the clean version of derby and my patched version. I ran 3 groups of test, each 
group running derbynet/dataSourcePermissions_net.java 20 times and these were 
my results (Apologies if there are formatting errors here):
                    Clean            Patched
Test 1     1/20 (5%)          5/20   (25%)
Test 2     3/20 (15%)        3/20   (15%)
Test 3     3/20 (15%)        4/20   (20%)
Total       7/60 (11.66%)   12/60 (20%)

While the patched version does have a somewhat higher error rate it should be 
noted that as part of my added tests I add two additional calls to the 
dataSourcePermissions_net.java shutdown method.

> Client DataSource should not require user property to be set
> ------------------------------------------------------------
>
>          Key: DERBY-406
>          URL: http://issues.apache.org/jira/browse/DERBY-406
>      Project: Derby
>         Type: Bug
>   Components: Network Client
>     Versions: 10.1.1.0, 10.2.0.0
>     Reporter: Kathey Marsden
>     Assignee: Philip Wilder
>  Attachments: DataSourceNoUser.java, Derby406_409_410.patch
>
> ClientDataSource should not require user to be set.  It should default to 
> user APP as described in:
> http://incubator.apache.org/derby/docs/adminguide/cadminappsclient.html
> This all seems to work ok for for DriverManager connections but fails for 
> ClientDataSource 
> run the attached repro 
> $ java DataSourceNoUser
> embedded no userid/password
> client userid/password set
> client no password
> client no userid/no password
> org.apache.derby.client.am.SqlException: null userid not supported
>         at 
> org.apache.derby.client.net.NetConnection.checkUser(NetConnection.java:998)
>         at 
> org.apache.derby.client.net.NetConnection.flowConnect(NetConnection.java:380)
>         at 
> org.apache.derby.client.net.NetConnection.initialize(NetConnection.java:233)
>         at 
> org.apache.derby.client.net.NetConnection.<init>(NetConnection.java:201)
>         at 
> org.apache.derby.jdbc.ClientDataSource.getConnection(ClientDataSource.java:156)
>         at 
> org.apache.derby.jdbc.ClientDataSource.getConnection(ClientDataSource.java:135)
>         at DataSourceNoUser.main(DataSourceNoUser.java:42)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to