Hello.

I deleted this comment myself.

Sorry.
I re-comment about this.

I was not clear yet to comment it.
I remenbered what I thought when coding.

Best regards.
/*

        Tomohito Nakayama
        [EMAIL PROTECTED]
        [EMAIL PROTECTED]
        [EMAIL PROTECTED]

        Naka
        http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/
----- Original Message ----- From: "Tomohito Nakayama (JIRA)" <[email protected]>
To: <[email protected]>
Sent: Tuesday, July 12, 2005 8:03 PM
Subject: [jira] Commented: (DERBY-397) Make it sure for the connection to be closed in drda.Database#close() even if Exception happens in conn.rollback().


[ http://issues.apache.org/jira/browse/DERBY-397?page=comments#action_12315554 ]

Tomohito Nakayama commented on DERBY-397:
-----------------------------------------

Well ...
New close method does not need to exist .

On the assumption that transaction is always made inactive when closing connection was proceeding,
there would be no need to avoid checking transaction.


And issue of  lock timeout....
Is this the reason why rollback is executed in drda.Database#close() ?

I will test it.





Make it sure for the connection to be closed in drda.Database#close() even if Exception happens in conn.rollback().
-------------------------------------------------------------------------------------------------------------------

         Key: DERBY-397
         URL: http://issues.apache.org/jira/browse/DERBY-397
     Project: Derby
        Type: Sub-task
  Components: Network Server
    Reporter: Tomohito Nakayama
    Assignee: Tomohito Nakayama
Attachments: derbyall_pass.txt, derbyall_report.txt, jdbcTrans.java, surveyDERBY397.patch.txt

If exeption was happen in conn.rollback() In the code of drda.Database#close,
that connection was not closed and would be leaked.
http://svn.apache.org/repos/asf/incubator/derby/code/trunk/java/drda/org/apache/derby/impl/drda/Database.java
Make it sure to close connection between drda and engine, when drda.Database#close was called.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
  http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
  http://www.atlassian.com/software/jira




--
No virus found in this incoming message.
Checked by AVG Anti-Virus.
Version: 7.0.323 / Virus Database: 267.8.12/46 - Release Date: 2005/07/11





--
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.323 / Virus Database: 267.8.12/46 - Release Date: 2005/07/11

Reply via email to