Dyre, are you on hold with this, or is it moving forward?
Thanks, David Dyre Tjeldvoll (JIRA) wrote:
[ http://issues.apache.org/jira/browse/DERBY-336?page=all ] Dyre Tjeldvoll updated DERBY-336: --------------------------------- Attachment: derby-336.diff derby-336.stat derbyall_report.txt New patch, stat output and derbyall_report based on comments from David Van Couvering.The wrong overload of StandardException::newException() is used in some cases ----------------------------------------------------------------------------- Key: DERBY-336 URL: http://issues.apache.org/jira/browse/DERBY-336 Project: Derby Type: Bug Environment: Any Reporter: Dyre Tjeldvoll Assignee: Dyre Tjeldvoll Priority: Trivial Attachments: derby-336.diff, derby-336.stat, derbyall_report.txt When looking at DERBY-128 it became clear that the wrong overload of StandardException::newException() was used when reporting SQLState.SERVICE_DIRECTORY_CREATE_ERROR. The message string only takes one parameter so only one additional parameter (other than Throwable) should be used: PersistentServiceImpl.java:676 throw StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR, serviceDirectory, null); // Calls StandardException.newException(String, Object, Object)// Should call StandardException.newException(String, Object)? Or StandardException.newException(String, Throwable, Object)? With the IOException as // Throwable?PersistentServiceImpl.java:692 throw StandardException.newException(SQLState.SERVICE_DIRECTORY_CREATE_ERROR, name, t); // Calls StandardException.newException(String, Object, Object) // Should call StandardException.newException(String, Throwable, Object)? BaseDataFileFactory.java:279 throw StandardException.newException( SQLState.SERVICE_DIRECTORY_CREATE_ERROR, dataDirectory, ioe); // Calls StandardException.newException(String, Object, Object) // Should call StandardException.newException(String, Throwable, Object)?
