OK, I'm running build and derbyall and will commit if all looks good...
David
Army wrote:
David Van Couvering wrote:
Hi, Rick. Once this gets approval from Army and Shreyas I'll go
ahead and check it in.
David
Rick Hillegas wrote:
I have attached a new rev of the fix to bug 171. This rev addresses
Army's concerns.
Cheers,
-Rick
The new patch addresses the concerns I brought up earlier, and the
comments in DERBY-171 now explain the changes to "refActions1" in a
good amount of detail. I ran the modified "update.sql" and
"delete.sql" tests locally with the patch applied and they both
passed. Since I haven't noticed any other issues with new patch, I
give it my +1.
Thanks to Rick for answering my questions and addressing my comments,
Army
begin:vcard
fn:David Van Couvering
n:Van Couvering;David
org:Sun Microsystems, Inc.;Database Technology Group
email;internet:[EMAIL PROTECTED]
title:Senior Staff Software Engineer
tel;work:510-550-6819
tel;cell:510-684-7281
x-mozilla-html:TRUE
version:2.1
end:vcard
