On Aug 22, 2005, at 8:00 AM, Philip Wilder (JIRA) wrote:

Incorrect insane build on windows platform
------------------------------------------

I've found that Derby will not build sane properly for me. I have isolated it to here:

  <target name="evaluate.sane">
    <condition property="generate.sane">
      <equals arg1="${sane}" arg2="true"/>
    </condition>
  </target>

The scope of the generate.sane property is limited to this target (only tested in a Windows XP environment), ergo it will always be an insane build. Patch to follow shortly.

*scratches head*

Well, it works, but i'm not sure why.  From the Ant docs:

"Properties are immutable: whoever sets a property first freezes it for the rest of the build; they are most definitely not variable."

Once generate.sane is set by the <condition>, it shouldn't go out of scope: it should be set for the rest of the build.

Oh well, also fixed another problem if sane just wasn't set at all with:

    <condition property="generate.sane">
      <or>
        <equals arg1="${sane}" arg2="true"/>
        <not>
          <isset property="${sane}"/>
        </not>
      </or>
    </condition>

Committed, revision 234508.

andrew

Reply via email to