Hi,
I have attached a review package to Jira entry Derby-421 with following comments. Please send me any feedback.
"
Attaching a patch for this JIRA entry. Following is some information on the patch.
When a connection object is obtained through XADataSource, it can be part of a local transaction or it can be attached to a global transaction. The state of the connection object can be different depending on whether it is used in local transaction or global transaction. Among other state information, isolation level is saved as part of the connection object's state information. This isolation level state is set correctly when isolation level is set using JDBC api. But it gets out of sync when SQL is used to set the isolation level state. In order to fix this, I have added a flag in GenericLanguageConnectionContext which will get set to true anytime isolation level is set using JDBC/SQL api. And this flag is later used to keep the isolation level state information uptodate in BrokeredConnection. The classes changed by this fix are as follows.
svn stat
M java\engine\org\apache\derby\impl\sql\conn\GenericLanguageConnectionContext.java
M java\engine\org\apache\derby\iapi\sql\conn\LanguageConnectionContext.java
M java\engine\org\apache\derby\iapi\jdbc\BrokeredConnection.java
M java\engine\org\apache\derby\iapi\jdbc\BrokeredConnectionControl.java
M java\engine\org\apache\derby\jdbc\EmbedPooledConnection.java
M java\engine\org\apache\derby\jdbc\EmbedXAConnection.java
M java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\checkDataSource.java
M java\testing\org\apache\derbyTesting\functionTests\master\checkDataSource.out
M java\testing\org\apache\derbyTesting\functionTests\master\checkDataSource30.out
"
When a connection object is obtained through XADataSource, it can be part of a local transaction or it can be attached to a global transaction. The state of the connection object can be different depending on whether it is used in local transaction or global transaction. Among other state information, isolation level is saved as part of the connection object's state information. This isolation level state is set correctly when isolation level is set using JDBC api. But it gets out of sync when SQL is used to set the isolation level state. In order to fix this, I have added a flag in GenericLanguageConnectionContext which will get set to true anytime isolation level is set using JDBC/SQL api. And this flag is later used to keep the isolation level state information uptodate in BrokeredConnection. The classes changed by this fix are as follows.
svn stat
M java\engine\org\apache\derby\impl\sql\conn\GenericLanguageConnectionContext.java
M java\engine\org\apache\derby\iapi\sql\conn\LanguageConnectionContext.java
M java\engine\org\apache\derby\iapi\jdbc\BrokeredConnection.java
M java\engine\org\apache\derby\iapi\jdbc\BrokeredConnectionControl.java
M java\engine\org\apache\derby\jdbc\EmbedPooledConnection.java
M java\engine\org\apache\derby\jdbc\EmbedXAConnection.java
M java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\checkDataSource.java
M java\testing\org\apache\derbyTesting\functionTests\master\checkDataSource.out
M java\testing\org\apache\derbyTesting\functionTests\master\checkDataSource30.out
"
thanks,
Mamta
