[ http://issues.apache.org/jira/browse/DERBY-530?page=comments#action_12323245 ]
Kathey Marsden commented on DERBY-530: -------------------------------------- Thanks Deepa for the review. I will fix up the code comments. svn add bites me again. On the test, I agree that additional tests for all the attributes should be added, and started to do that, but found DERBY-530 growing, so thought it best to check in with the tests that the embedded attributes get passed to the server and the client attributes get processed and put a todo in the test to add the additional attributes. I'll file a separate Jira entry to enhance the test. When I ran derbyAll, I found there is another problem too with the test that tracefile goes to a different subdirectory based on whether the test is run in a suite or independently. I will fix that too. > ClientDriver ignores Properties object in connect(String url, Properties > connectionProperties) method > ----------------------------------------------------------------------------------------------------- > > Key: DERBY-530 > URL: http://issues.apache.org/jira/browse/DERBY-530 > Project: Derby > Type: Bug > Components: Network Client > Versions: 10.1.1.0 > Environment: windows XP, JRE 1.5.0_04 > Reporter: Piet Blok > Assignee: Kathey Marsden > Attachments: DERBY530.diff > > In contrast to EmbeddedDriver, a connection attribute create=true is not > recognized when presented as a property in a Properties object. > As a workaround I append the attributes from the Properties object to the > url string before invoking the connect() method: then a new database is > created and a connection is established. > Next code fragment illustrates the bug and the workaround: > private static final ClientDriver clientDriver = new ClientDriver(); > private Connection getClientConnection(String database, > Properties connectionProperties) throws SQLException { > try { > System.out.println("Try to connect with properties"); > String connectionURL = "jdbc:derby://127.0.0.1:1527/" + database; > System.out.println("connectionURL: " + connectionURL); > Connection rv = clientDriver.connect(connectionURL, > connectionProperties); > System.out.println("Connection: " + rv); > return rv; > } catch (SQLException e) { > System.out.println("Try to connect with URL attributes"); > StringBuffer sb = new StringBuffer(); > for (Enumeration enu = connectionProperties.propertyNames(); enu > .hasMoreElements();) { > String key = (String) enu.nextElement(); > sb.append(';'); > sb.append(key); > sb.append('='); > sb.append(connectionProperties.getProperty(key, "")); > } > String connectionURL = "jdbc:derby://127.0.0.1:1527/" + database > + sb.toString(); > System.out.println("connectionURL: " + connectionURL); > Connection rv = clientDriver.connect(connectionURL, > connectionProperties); > System.out.println("Connection: " + rv); > System.out > .println("!!!!!!!!!!! seems a bug: Properties argument in > ClientDriver.connect(String, Properties) has not been used"); > return rv; > } > } -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
