[ http://issues.apache.org/jira/browse/DERBY-453?page=comments#action_12329492 ]
Kathey Marsden commented on DERBY-453: -------------------------------------- Deepa and I spoke briefly about this patch. Here's the summary of my comments. - There a couple of uses of Double still that can be removed 1) in setObject it is used. 2) new Double() is used in getBigDecimalString() to verify that the value is a number and an exception thrown that matches the server internal message that is thrown if you do getBigDecimal on a non numeric value. This may not work in all cases and seems a bit confusing. Maybe better to just let the caller deal with the value as returned from getString I noted that StmtCloseFunTest.java has been changed to use long literal values in the Date Constructor. (The test was using a deprecated constructor.) Deepa said this was because Aparently J2ME doesn't have a Calendar class. so it's not clear how to construct the date except by this method which other tests use. > Create a test wrapper to run tests using BigDecimal in J2ME/CDC/Foundation > -------------------------------------------------------------------------- > > Key: DERBY-453 > URL: http://issues.apache.org/jira/browse/DERBY-453 > Project: Derby > Type: Improvement > Components: Test > Environment: J2ME/CDC/Foundation using IBM's WCTME 5.7 > Reporter: Deepa Remesh > Assignee: Deepa Remesh > Priority: Minor > Attachments: derby-453.diff, derby-453.status, > derby_453_outparams_patch1.diff, derby_453_outparams_patch1.status, > derby_453_outparams_patch2.diff, derby_453_outparams_patch3.diff > > The following tests are currently excluded in J2ME/CDC/Foundation because > they use BigDecimal class. > I18NImportExport > batchUpdate > LOBTest > parameterMapping > resultset > StmtCloseFunTest > cast > functions > outparams > procedure > triggerRefClause > wisconsin > iepnegativetests > ieptests > importExportThruIJ > importExport > To run the above tests in this environment, test utility classes have to be > written so that the methods using BigDecimal are redirected depending on the > VM environment. The initial goal is to submit a patch for the test > resultset.java. After this, sub-tasks will be opened if changes are needed to > run the other tests. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
